THRIFT-4526: Added Rubocop harness to enforce Ruby code style#3333
Open
kpumuk wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-4526: Added Rubocop harness to enforce Ruby code style#3333kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk wants to merge 1 commit intoapache:masterfrom
Conversation
kpumuk
changed the title
mergeable
bot
added
ruby
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce Rubocop harness for all Ruby code in the repository (Ruby library, integration tests, tutorials). All the rules are intentionally disabled at the moment, the goal is to gradually introduce them, while cleaning up the codebase to bring it up to a consistent standard.
Canonical Rubocop configuration will be stored in
lib/rb/.rubocop.yml.[skip ci]anywhere in the commit message to free up build resources.